Skip to content

fix: cherry-pick needed changes in devstack#41

Merged
ClaytonNorthey92 merged 5 commits into
hemifrom
clayton/cherry-pick-devstack
Mar 24, 2026
Merged

fix: cherry-pick needed changes in devstack#41
ClaytonNorthey92 merged 5 commits into
hemifrom
clayton/cherry-pick-devstack

Conversation

@ClaytonNorthey92
Copy link
Copy Markdown

cherry-pick changes in devstack

solve conflicts

remove unused deps

ajsutton and others added 5 commits March 24, 2026 13:00
…thereum-optimism#19679)

* op-acceptance-tests: run acceptance tests in parallel

Add a native acceptance test runner that expands acceptance-tests.yaml gates
and schedules package-level go test runs concurrently, while preserving
the logs and junit artifacts expected by CI.

Remove shared-process-state blockers in acceptance tests and devstack
presets, convert the acceptance tree from SerialT to ParallelT, and
expand directory-only gate entries like interop/sync into concrete child
packages so the runner matches existing gate semantics.

ci: honor op-acceptance-tests no_output_timeout

ci: restore memory-all aggregator check

* op-devstack: add sysgo.SkipOnOpReth helper, skip two tests failing on op-reth

Skip TestSupernodeInteropInvalidMessageReplacement and
TestSupernodeSameTimestampInvalidTransitive when running with op-reth,
as they panic due to a safe head mismatch in EngineController
(ethereum-optimism#19411).

Introduces sysgo.SkipOnOpReth(t, reason) and the DevstackL2ELKindEnvVar
constant, replacing hardcoded env var strings in multichain_supernode_runtime.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* op-acceptance-tests: skip TestSupernodeSameTimestampCycle on op-reth

Same safe head mismatch panic as the other two supernode interop tests
(ethereum-optimism#19411).

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* op-acceptance-tests: restore gate filtering for op-reth CI jobs

Add gate file system (op-acceptance-tests/gates/base.txt) to replace
the old acceptance-tests.yaml gate routing. The justfile reads package
lists from gate files and passes them to gotestsum.

- op-geth job runs all tests (no gate)
- op-reth jobs run only base gate packages
- Split per-test logs via split-test-logs.sh after test runs

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix(ci): remove scheduled-docker-publish re-added during rebase

The rebase incorrectly re-introduced the scheduled-docker-publish
workflow and c-docker_publish_dispatch parameter that were removed
by ethereum-optimism#18821 and ethereum-optimism#19530 when docker builds migrated to GitHub Actions.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* ci: remove "Print results (all)" step from op-acceptance-tests

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Teddy Knox <teddy@oplabs.co>
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…reum-optimism#19242)

* op-acceptance: Add tests for invalid messages to op-acceptance.

Currently fail to setup because supernode doesn't actually remove the invalid transaction.

* Wait for cross safe as well

* Add simple replacement block test

* Check we can still use a chain after a replacement block.

* Cleanup

* Enable interop activation at genesis when interop is scheduled.

* Add more validation and logging.

* chore: fix goimports formatting

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* fix(op-acceptance): skip TestInteropFaultProofs_InvalidBlock

Skip until supernode removes invalid transactions from blocks.
See ethereum-optimism#19411.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* chore: remove debug logger.Info statements from provider_supernode

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* Fix preset used.

---------

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
…ite (ethereum-optimism#19635)

Add 60s timeout to Read/ReadArray and 5m timeout to Write in the DSL
contract helpers. Previously these used the base test context (up to 2h),
so a single stalled RPC call to in-memory geth could hang a test for the
full package timeout under CI resource contention.

This fixes TestChallengerRespondsToMultipleInvalidClaims and TestProposer
hangs, and prevents similar issues in all tests using the contract DSL.

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
cherry-pick changes in devstack

solve conflicts

remove unused deps
Copy link
Copy Markdown

@jcvernaleo jcvernaleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@ClaytonNorthey92 ClaytonNorthey92 merged commit cc8bc1c into hemi Mar 24, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants